Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use .LAST k-keyword in min(SPC)/max(SPC) #209

Merged
merged 2 commits into from
Mar 3, 2021
Merged

use .LAST k-keyword in min(SPC)/max(SPC) #209

merged 2 commits into from
Mar 3, 2021

Conversation

brownag
Copy link
Member

@brownag brownag commented Mar 2, 2021

Following from #207 (updates to fillHzGaps). This gap-fill method now supports filling to the surface and filling to depth. The default fill-to depths are 0 for the to_top argument and max(SPC) isdefault to_bottom.

min and max have benefitted from the "k-keyword" .LAST which was introduced in #201 and discussed at end of #175

@dylanbeaudette dylanbeaudette merged commit e2f48bc into master Mar 3, 2021
brownag added a commit that referenced this pull request Mar 11, 2021
@brownag
Fix #209 for data.table SPCs
dd289be
@brownag brownag deleted the optimizeSPCMinMax branch March 23, 2021 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanbeaudette dylanbeaudette Awaiting requested review from dylanbeaudette

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brownag @dylanbeaudette