add functions in support of new ndaujs package for exchange integrators #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmcnierney
reviewed
Apr 5, 2021
| jsLogReject(callback, "error decoding data from hex: %s", err) | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
Should we check for correct seed length here? I don't think it's necessary, since a bad key length will just cause GenerateFromSeed to return an error.
edmcnierney
reviewed
Apr 5, 2021
| return | ||
| } | ||
|
|
||
| addr, err := address.Generate(address.KindExchange, key.KeyBytes()) |
There was a problem hiding this comment.
If this is for general ndaujs usage we shouldn't hard-code this as an Exchange-type key.
edmcnierney
reviewed
Apr 5, 2021
|
|
||
| // Generate a high-level keypair from a given seed | ||
| func GenerateFromSeed(al Algorithm, seed []byte) (public PublicKey, private PrivateKey, err error) { | ||
| pubBytes, privBytes, err := al.GenerateFromSeed(seed) |
There was a problem hiding this comment.
Same question as earlier - is it worth it to do any kind of checking on the seed here (as in ed25519 below)? It won't any difference in the outcome, just in the error logged.
edmcnierney
reviewed
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.