Update Dockerfile and update Makefile #292
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Dockerfile and update Makefile: - Remove old dockerfile - Add new dockerfile with debian debian:bullseye-slim - Update makefile with new dockerfile Signed-off-by: Bensuperpc <[email protected]>
Fix makefile error and Github action Signed-off-by: Bensuperpc <[email protected]>
Vogtinator
requested changes
Mar 16, 2022
There was a problem hiding this comment.
IMO the split of toolchain + SDK images is important to avoid unnecessary rebuilds. While locally there is a cache, there isn't in the CI environment, so only rebuilding the toolchain image on manual triggers makes more sense.
Currently it uses bullseye for building the toolchain and SDK and buster for the SDK image, any reason for that? Copying binaries from newer to older releases is not going to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Dockerfile and update Makefile:
Docker repos exemple : https://github.com/Bensuperpc/Docker-Ndless
Docker hub : https://hub.docker.com/r/bensuperpc/ndless
Signed-off-by: Bensuperpc [email protected]