Allow sabmitting the same poyload #461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Feature Environment (dev-461)Terraform Initialization ⚙️
|
| @@ -58,6 +59,45 @@ pub async fn request_sign( | |||
| Ok((payload, account, tx_hash)) | |||
| } | |||
|
|
|||
| pub async fn request_sign_sync( | |||
There was a problem hiding this comment.
we shouldn't need to test both versions though. They're pretty much the same, like there's no difference besides the calling mechanism. They're going to be hitting the same code path in near node side anyways
There was a problem hiding this comment.
We'll fix this one later
There was a problem hiding this comment.
I understand that we are testing the same code from our perspective. It's more of a "let's check if MPC returns the signature in time" test. Can be done differently, but this one seems the most convenient to me.
|
Maybe let's hold off merging this one since @DavidM-D is going to make a separate MPC service for people to make use of and test |
|
I might be reading this wrong, I think this might be a bit worse than what we have right now. Since two people can be waiting on a response for the same payload, but they both will try to evict the response when they get it, only one of them (randomly selected) will ever succeed. This seems worse than the current solution of saying "you're too late" immediately to the second caller. As discussed, I think we should either count the number of outstanding requests for a good fix. Failing that, I'd remove the eviction of results (with a big TODO mentioning the memory leak it causes) which would allow both results to succeed. |
|
Ok, I will invest more time into it once I have it. |
|
OK this is causing @firatNEAR's team problems. If we can't get the dummy signatures working, let's do a hacky fix and work out how to do it right on Monday. |
|
I already removed evicting the result, so we just basically have the signature cached for the lifetime of the contract now. Lets merge this then |
Terraform Feature Environment Destroy (dev-461)Terraform Initialization ⚙️
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
signcallnear-fetchretries and throws "Signature for this payload already requested". I'm still not sure how and why that works in NEAR CLI.I do not think that check is important now, but it's causing many problems for testing and development. We will need to redesign it when we have more time.