Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increment and refactor number of hops for routed messages #12188

Merged
merged 8 commits into from
Dec 20, 2024

Conversation

stedfn
Copy link
Contributor

@stedfn stedfn commented Oct 4, 2024

No description provided.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.49%. Comparing base (2e8dcea) to head (a9cbfe1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12188      +/-   ##
==========================================
+ Coverage   70.47%   70.49%   +0.02%     
==========================================
  Files         845      845              
  Lines      172255   172251       -4     
  Branches   172255   172251       -4     
==========================================
+ Hits       121389   121422      +33     
+ Misses      45766    45733      -33     
+ Partials     5100     5096       -4     
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (+<0.01%) ⬆️
db-migration 0.16% <0.00%> (+<0.01%) ⬆️
genesis-check 1.36% <0.00%> (+<0.01%) ⬆️
linux 69.35% <100.00%> (+0.01%) ⬆️
linux-nightly 70.07% <100.00%> (-0.01%) ⬇️
pytests 1.66% <0.00%> (+<0.01%) ⬆️
sanity-checks 1.47% <0.00%> (+<0.01%) ⬆️
unittests 70.32% <100.00%> (+0.02%) ⬆️
upgradability 0.20% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stedfn stedfn self-assigned this Oct 4, 2024
@stedfn stedfn requested a review from saketh-are October 4, 2024 11:24
@stedfn stedfn marked this pull request as ready for review October 4, 2024 11:24
@stedfn stedfn requested a review from a team as a code owner October 4, 2024 11:24
Copy link
Collaborator

@saketh-are saketh-are left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Could be worth adding a couple of basic unit tests covering the 0-hop and 1-hop cases.

@stedfn stedfn changed the title fix: increment num hops for routed messages fix: increment and refactor number of hops for routed messages Oct 11, 2024
@stedfn
Copy link
Contributor Author

stedfn commented Oct 11, 2024

@saketh-are I cleaned it up a bit more and added an assert in an integration test to confirm it gets incremented. Let me know if you are happy with the changes

Copy link
Collaborator

@saketh-are saketh-are left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM, left a couple of small comments

chain/network/src/stats/metrics.rs Outdated Show resolved Hide resolved
@stedfn stedfn added this pull request to the merge queue Dec 20, 2024
Merged via the queue into master with commit 7e0b24d Dec 20, 2024
28 checks passed
@stedfn stedfn deleted the stefan/fix/fix_num_hops branch December 20, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants