-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: increment and refactor number of hops for routed messages #12188
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12188 +/- ##
==========================================
+ Coverage 70.47% 70.49% +0.02%
==========================================
Files 845 845
Lines 172255 172251 -4
Branches 172255 172251 -4
==========================================
+ Hits 121389 121422 +33
+ Misses 45766 45733 -33
+ Partials 5100 5096 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Could be worth adding a couple of basic unit tests covering the 0-hop and 1-hop cases.
@saketh-are I cleaned it up a bit more and added an assert in an integration test to confirm it gets incremented. Let me know if you are happy with the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM, left a couple of small comments
No description provided.