chain: don't skip early transaction validity checks in state witnesses

chain/chain/src/stateless_validation/chunk_validation.rs

@@ -67,6 +67,18 @@ impl MainTransition {
 pub struct PreValidationOutput {
     pub main_transition_params: MainTransition,
     pub implicit_transition_params: Vec<ImplicitTransitionParams>,
+    /// List of the transactions that are valid and should be processed by e.g.
+    /// `validate_chunk_state_witness`.
+    ///
+    /// This list is exactly the length of the corresponding `ChunkStateWitness::transactions`
+    /// field. Element at the index N in this array corresponds to an element at index N in the
+    /// transactions list.
+    ///
+    /// Transactions for which a `false` is stored here ought to be ignored/dropped/skipped.
+    ///
+    /// All elements will be true for protocol versions where `RelaxedChunkValidation` is not
+    /// enabled.
+    pub transaction_validity_check_passed: Vec<bool>,
 }
 
 #[derive(Clone)]
@@ -369,11 +381,20 @@ pub fn pre_validate_chunk_state_witness(
 
     let current_protocol_version =
         epoch_manager.get_epoch_protocol_version(&state_witness.epoch_id)?;
-    if !checked_feature!(
+    let transaction_validity_check_passed = if checked_feature!(
         "protocol_feature_relaxed_chunk_validation",
         RelaxedChunkValidation,
         current_protocol_version
     ) {
+        if last_chunk_block.header().is_genesis() {
+            vec![true; state_witness.transactions.len()]
+        } else {
+            let prev_block_header =
+                store.get_block_header(last_chunk_block.header().prev_hash())?;
+            let mut check = chain.transaction_validity_check(prev_block_header);
+            state_witness.transactions.iter().map(|t| check(t)).collect::<Vec<_>>()
+        }
+    } else {
         let new_transactions = &state_witness.new_transactions;
         let (new_tx_root_from_state_witness, _) = merklize(&new_transactions);
         let chunk_tx_root = state_witness.chunk_header.tx_root();
@@ -420,7 +441,8 @@ pub fn pre_validate_chunk_state_witness(
                 }
             };
         }
-    }
+        vec![true; state_witness.transactions.len()]
+    };
 
     let main_transition_params = if last_chunk_block.header().is_genesis() {
         let epoch_id = last_chunk_block.header().epoch_id();
@@ -462,7 +484,11 @@ pub fn pre_validate_chunk_state_witness(
         })
     };
 
-    Ok(PreValidationOutput { main_transition_params, implicit_transition_params })
+    Ok(PreValidationOutput {
+        main_transition_params,
+        implicit_transition_params,
+        transaction_validity_check_passed,
+    })
 }
 
 /// Validate that receipt proofs contain the receipts that should be applied during the
@@ -611,7 +637,21 @@ pub fn validate_chunk_state_witness(
     let (mut chunk_extra, mut outgoing_receipts) =
         match (pre_validation_output.main_transition_params, cache_result) {
             (MainTransition::Genesis { chunk_extra, .. }, _) => (chunk_extra, vec![]),
-            (MainTransition::NewChunk(new_chunk_data), None) => {
+            (MainTransition::NewChunk(mut new_chunk_data), None) => {
+                let mut validity_iterator =
+                    pre_validation_output.transaction_validity_check_passed.iter();
+                new_chunk_data.transactions.retain(|t| {
+                    let valid = *validity_iterator.next().unwrap();
+                    if !valid {
+                        tracing::debug!(
+                            target: "chain",
+                            message="discarding invalid transaction",
+                            tx=%t.get_hash()
+                        );
+                    }
+                    valid
+                });
+
                 let chunk_header = new_chunk_data.chunk_header.clone();
                 let NewChunkResult { apply_result: mut main_apply_result, .. } = apply_new_chunk(
                     ApplyChunkReason::ValidateChunkStateWitness,