Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resharding): split shard twice #12635

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

staffik
Copy link
Contributor

@staffik staffik commented Dec 17, 2024

In the case a shard is split again, we should use ShardUId prefix of grandparent.
Add a testloop for this scenario. The test is ignored for now, since we currently do not support multiple reshardings without node restart.

@staffik staffik force-pushed the stafik/resharding/two-reshardings branch from 44da438 to e2fdf0d Compare December 17, 2024 12:22
@staffik staffik marked this pull request as ready for review December 19, 2024 12:51
@staffik staffik requested a review from a team as a code owner December 19, 2024 12:51
@staffik staffik requested review from saketh-are, wacban and shreyan-gupta and removed request for saketh-are December 19, 2024 12:51
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 51.35135% with 18 lines in your changes missing coverage. Please review.

Project coverage is 70.48%. Comparing base (9b1e675) to head (db1eb1d).

Files with missing lines Patch % Lines
integration-tests/src/test_loop/utils/setups.rs 35.71% 17 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12635   +/-   ##
=======================================
  Coverage   70.48%   70.48%           
=======================================
  Files         845      845           
  Lines      172247   172279   +32     
  Branches   172247   172279   +32     
=======================================
+ Hits       121405   121434   +29     
- Misses      45743    45746    +3     
  Partials     5099     5099           
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (ø)
db-migration 0.16% <0.00%> (ø)
genesis-check 1.36% <0.00%> (-0.01%) ⬇️
linux 69.34% <8.10%> (-0.01%) ⬇️
linux-nightly 70.07% <51.35%> (-0.02%) ⬇️
pytests 1.66% <0.00%> (-0.01%) ⬇️
sanity-checks 1.47% <0.00%> (-0.01%) ⬇️
unittests 70.31% <51.35%> (+<0.01%) ⬆️
upgradability 0.20% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant