fix(resharding): split shard twice #12635
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staffik
force-pushed
the
stafik/resharding/two-reshardings
branch
from
44da438 to
e2fdf0d
Compare
staffik
requested review from
saketh-are,
wacban and
shreyan-gupta
and removed request for
saketh-are
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12635 +/- ##
=======================================
Coverage 70.48% 70.48%
=======================================
Files 845 845
Lines 172247 172279 +32
Branches 172247 172279 +32
=======================================
+ Hits 121405 121434 +29
- Misses 45743 45746 +3
Partials 5099 5099
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Fix done in #12688, test will be added later. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
Introduce the fix from #12635 now, will add test later as it requires one of two: - memtrie support for double resharding without restart - testloop support for restarting a node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case a shard is split again, we should use
ShardUIdprefix of grandparent.Add a testloop for this scenario. The test is ignored for now, since we currently do not support multiple reshardings without node restart.