Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate_state_witness_parts cannot fail #12645

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

akhi3030
Copy link
Collaborator

Does not return a Result from generate_state_witness_parts() as it cannot fail and some knock on removal of unnecessary Results.

@akhi3030 akhi3030 requested a review from a team as a code owner December 18, 2024 16:04
@akhi3030 akhi3030 requested a review from saketh-are December 18, 2024 16:04
@akhi3030 akhi3030 enabled auto-merge December 18, 2024 16:04
@akhi3030 akhi3030 added this pull request to the merge queue Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.49%. Comparing base (e692d20) to head (9d31908).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12645      +/-   ##
==========================================
- Coverage   70.49%   70.49%   -0.01%     
==========================================
  Files         845      845              
  Lines      172247   172247              
  Branches   172247   172247              
==========================================
- Hits       121426   121417       -9     
- Misses      45725    45734       +9     
  Partials     5096     5096              
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (ø)
db-migration 0.16% <0.00%> (ø)
genesis-check 1.36% <0.00%> (ø)
linux 69.34% <100.00%> (-0.01%) ⬇️
linux-nightly 70.09% <100.00%> (+<0.01%) ⬆️
pytests 1.66% <0.00%> (ø)
sanity-checks 1.47% <0.00%> (ø)
unittests 70.31% <100.00%> (-0.01%) ⬇️
upgradability 0.20% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2024
@akhi3030 akhi3030 enabled auto-merge December 19, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants