test: reenable test on macos

[eagr]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.47%. Comparing base (e692d20) to head (f2b1e41).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #12647      +/-   ##
==========================================
- Coverage   70.49%   70.47%   -0.02%     
==========================================
  Files         845      845              
  Lines      172247   172247              
  Branches   172247   172247              
==========================================
- Hits       121426   121392      -34     
- Misses      45725    45753      +28     
- Partials     5096     5102       +6     

Flag	Coverage Δ
backward-compatibility	0.16% <ø> (ø)
db-migration	0.16% <ø> (ø)
genesis-check	1.36% <ø> (ø)
linux	69.33% <ø> (-0.02%)	⬇️
linux-nightly	70.08% <ø> (-0.01%)	⬇️
pytests	1.66% <ø> (ø)
sanity-checks	1.47% <ø> (ø)
unittests	70.30% <ø> (-0.02%)	⬇️
upgradability	0.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eagr]

I think we could reenable some of the tests for macos in ci. Except for runtime-params-estimator which is kinda blocked by at least one of the underlying dep (wasmer-runtime-core-near doesn't support aarch64 w/ macos, but I could totally off of the reason), other previously disabled tests are working now. Is there an intent to enable runtime-params-estimator for apple silicon? If not, I could just wrap it up.

I understand that macos tests are not gonna be run in a per PR basis. I'll revert the change to ci.yml, don't worry :)

cc @nagisa @andrei-near

[eagr]

Have run into this a couple times. Seems kinda flaky, do we need to address it?

[nagisa]

The flakiness has been explored here. First thing would be to have somebody reproduce the failure locally and then investigate where the segv is coming from.

[nagisa]

Since the unignored tests appear to be passing now, LGTM.

[eagr]

Idk how to reproduce it locally. If this happens often enough, maybe enable core dumps (temporarily), and upload the dumps somewhere for debugging?