feat: fix chunk producer staking threshold #12660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Longarithm
approved these changes
Dec 20, 2024
Comment on lines
130
to
131
| // (reason of "approximately 6x": ./fix_stake_threshold.rs, but it's irrelevant here) | ||
| // so test3's proposal will not be approved |
There was a problem hiding this comment.
Let's just say that 6 corresponds to the number of shards, especially if fix_stake_threshold is irrelevant.
eagr
force-pushed
the
fix-chunk-producer-stake
branch
from
c556314 to
34bf46e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12660 +/- ##
==========================================
+ Coverage 70.49% 70.51% +0.02%
==========================================
Files 845 845
Lines 172247 172257 +10
Branches 172247 172257 +10
==========================================
+ Hits 121421 121465 +44
+ Misses 45727 45696 -31
+ Partials 5099 5096 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of empty seats, the seat price of cp used to depend on the number of existing shards (approximately
block_producer_threshold / num_shard), but it is no longer the case. Hence the fix.cc @Longarithm @wacban