fix(testloop): set epoch length in testloop #12664
Open
+8
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staffik
commented
Dec 23, 2024
| @@ -503,6 +503,7 @@ impl TestLoopBuilder { | |||
| let genesis = self.genesis.as_ref().unwrap(); | |||
| let epoch_config_store = self.epoch_config_store.as_ref().unwrap(); | |||
| let mut client_config = ClientConfig::test(true, 600, 2000, 4, is_archival, true, false); | |||
| client_config.epoch_length = genesis.config.epoch_length; | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12664 +/- ##
==========================================
- Coverage 70.50% 70.48% -0.02%
==========================================
Files 845 845
Lines 172257 172258 +1
Branches 172257 172258 +1
==========================================
- Hits 121442 121420 -22
- Misses 45717 45738 +21
- Partials 5098 5100 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Trisfald
approved these changes
Dec 24, 2024
| @@ -1146,8 +1144,7 @@ fn test_resharding_v3_yield_resume() { | |||
| vec![account_in_left_child, account_in_right_child], | |||
| ReceiptKind::PromiseYield, | |||
| )) | |||
| // TODO(resharding): test should work without changes to num_rpcs and track_all_shards | |||
| .num_rpcs(0) | |||
| // TODO(resharding): test should work without changes to track_all_shards | |||
| .track_all_shards(true) | |||
There was a problem hiding this comment.
We still have the issue of track_all_shards must be true, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some resharding tests failed if an RPC node was used to submit transactions.
It worked without RPC because
client0was used by default, and it turned out this client was a chunk validator for the child shard after resharding.It did not work with RPC (or any client other than
client0) because a transaction near epoch boundary was not forwarded toclient0. It was not forwarded becauseconfig.epoch_lengthwas not properly set in testloop.It has default value
10, while resharding tests use6. That causedget_next_epoch_id_if_at_boundaryto return different result that expected. In consequence, transaction was not sent toclient0, which was a chunk producer for next epoch.