chore: Remove NEP-491 #12818
Merged
chore: Remove NEP-491 #12818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12818 +/- ##
==========================================
- Coverage 70.37% 70.36% -0.01%
==========================================
Files 848 848
Lines 174870 174513 -357
Branches 174870 174513 -357
==========================================
- Hits 123064 122800 -264
+ Misses 46547 46468 -79
+ Partials 5259 5245 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pugachAG
approved these changes
Jan 28, 2025
| @@ -62,19 +61,7 @@ pub struct AccountV1 { | |||
| storage_usage: StorageUsage, | |||
| } | |||
|
|
|||
| impl AccountV1 { | |||
There was a problem hiding this comment.
could you please keep this, just remove permanent_storage_bytes field, later I will update it
pugachAG
approved these changes
Jan 30, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is ongoing work on global contracts that addresses the problem near/NEPs#491 was originally designed to solve. NEP-491 code is quite messy and has been around for about a year. We no longer see external interest in this feature, but if the need arises in the future, we can always restore the code.
Reverts most of (because some part is used by #12794):
Also, #11005 can be closed.