fix(state-parts-dump-check): check the right sync hash (#12975) #13028
+103
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the current epoch state sync feature is enabled, getting the state roots from the last block of the previous epoch no longer works. So in this PR we find the right sync hash if that protocol feature is enabled by iterating over the chunks in the new epoch until we find the right point.
VanBarbascu
force-pushed
the
2.5_state_parts_cherrypick
branch
from
3ed7e99 to
bc800b3
Compare
shreyan-gupta
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the current epoch state sync feature is enabled, getting the state roots from the last block of the previous epoch no longer works. So in this PR we find the right sync hash if that protocol feature is enabled by iterating over the chunks in the new epoch until we find the right point.