Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating old Argo docs and applying minor updates #268

Merged
merged 5 commits into from
Mar 28, 2023
Merged

Migrating old Argo docs and applying minor updates #268

merged 5 commits into from
Mar 28, 2023

Conversation

kcpevey
Copy link
Contributor

@kcpevey kcpevey commented Feb 2, 2023

This PR migrates over the old Argo docs and also provides some updates that are coming from PR nebari-dev/nebari#1639 .

Reference Issues or PRs

fixes #48

fixes #49

What does this implement/fix?

Put a x in the boxes that apply

  • Documentation Update

Testing

  • Did you test the pull request locally?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@netlify
Copy link

netlify bot commented Feb 2, 2023

Deploy Preview for nebari-docs ready!

Name Link
🔨 Latest commit 1e4098b
🔍 Latest deploy log https://app.netlify.com/sites/nebari-docs/deploys/641b178113178800079ac895
😎 Deploy Preview https://deploy-preview-268--nebari-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kcpevey kcpevey marked this pull request as ready for review February 2, 2023 19:51
@kcpevey
Copy link
Contributor Author

kcpevey commented Feb 2, 2023

I'm taking this out of draft for some feedback. I'd like to see what @ericdatakelly has been working on. I'm leaning towards getting this merged quickly rather than "making it fancy", but I'll let @pavithraes and @trallard respond to that.

@pavithraes pavithraes self-requested a review February 7, 2023 13:58
@pavithraes pavithraes added area: integration/Argo type: enhancement 💅🏼 New feature or request status: in review 👀 This PR is currently being reviewed by the team labels Feb 7, 2023
Copy link
Member

@pavithraes pavithraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kcpevey Thank you for working on this, it looks good to me.

I've mainly just added style-guide-related suggestions for consistency. Other than that, I think the using-argo.md can be moved to the how-tos section -- mainly because I think tutorials are intended to be to complete end-to-end examples? What do you think?

I do agree that we can merge this migrating PR and make updates as we go. :)

@kcpevey
Copy link
Contributor Author

kcpevey commented Mar 22, 2023

@pavithraes your requested changes have been made. This is ready for final review and merge!

Copy link
Member

@pavithraes pavithraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavithraes pavithraes merged commit 1f81952 into main Mar 28, 2023
@pavithraes pavithraes deleted the argo branch March 28, 2023 11:27
@pavithraes pavithraes added status: approved 💪🏾 This PR has been reviewed and approved for merge and removed status: in review 👀 This PR is currently being reviewed by the team labels Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: integration/Argo status: approved 💪🏾 This PR has been reviewed and approved for merge type: enhancement 💅🏼 New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

[DOC] How to enable and configure Argo-Workflow [DOC] Tutorial on using Argo Workflows
2 participants