-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating old Argo docs and applying minor updates #268
Conversation
✅ Deploy Preview for nebari-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I'm taking this out of draft for some feedback. I'd like to see what @ericdatakelly has been working on. I'm leaning towards getting this merged quickly rather than "making it fancy", but I'll let @pavithraes and @trallard respond to that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kcpevey Thank you for working on this, it looks good to me.
I've mainly just added style-guide-related suggestions for consistency. Other than that, I think the using-argo.md
can be moved to the how-tos section -- mainly because I think tutorials are intended to be to complete end-to-end examples? What do you think?
I do agree that we can merge this migrating PR and make updates as we go. :)
Co-authored-by: Pavithra Eswaramoorthy <[email protected]>
@pavithraes your requested changes have been made. This is ready for final review and merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
This PR migrates over the old Argo docs and also provides some updates that are coming from PR nebari-dev/nebari#1639 .
Reference Issues or PRs
fixes #48
fixes #49
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1
or#
in markdown).Non-text content
Any other comments?