Update Argo Workflows to latest version

docs/source/admin_guide/argo-workflows.md

@@ -1,26 +1,18 @@
 # Argo Workflows
 
 Argo Workflows is an open source container-native workflow engine for orchestrating parallel jobs on Kubernetes. Argo
-workflows comes enabled by default with Qhub deployments.
+workflows comes enabled by default with Nebari deployments.
 
 ## Accessing Argo Server
 
-If Argo Workflows is enabled, users can access argo workflows server at: `your-qhub-domain.com/argo`. Log in via
+If Argo Workflows is enabled, users can access argo workflows server at: `your-nebari-domain.com/argo`. Log in via
 Keycloak with your usual credentials.
 
-Refer to the [Argo documentation](https://argoproj.github.io/argo-workflows/) for further details on Argo Workflows.
-
-## Submitting a workflow via Argo Server
-
-You can submit a workflow by clicking "SUBMIT NEW WORKFLOW" on the landing page.
-
-![See Argo Server Landing Page](../images/argo-server-landing-page.png)
-
 ## Overrides of Argo Workflows Helm Chart values
 
-Argo Workflows is deployed using Argo Workflows Helm Chart version 0.13.1. The values.yaml for the helm chart can be
-overridden as needed via the overrides flag. The default values file can be found
-[here](https://github.com/argoproj/argo-helm/blob/argo-workflows-0.13.1/charts/argo-workflows/values.yaml). For example,
+Argo Workflows is deployed using the Argo Workflows Helm Chart. The values.yaml for the helm chart can be overridden as
+needed via the overrides flag. The default values file can be found
+[here](https://github.com/argoproj/argo-helm/blob/argo-workflows-0.22.9/charts/argo-workflows/values.yaml). For example,
 the following could be done to add additional environment variables to the controller container.
 
 ```yaml
@@ -35,10 +27,12 @@ argo_workflows:
 
 ## Disabling Argo Workflows
 
-To turn off the cluster monitoring on QHub deployments, simply turn off the feature flag within your `qhub-config.yaml`
-file. For example:
+To turn off the cluster monitoring on Nebari deployments, simply turn off the feature flag within your
+`nebari-config.yaml` file. For example:
 
 ```yaml
 argo_workflows:
   enabled: false
 ```
+
+Refer to the [Argo documentation](https://argoproj.github.io/argo-workflows/) for further details on Argo Workflows.

docs/source/user_guide/argo_workflows.md

@@ -0,0 +1,32 @@
+# Argo Workflows
+
+Argo Workflows is an open source container-native workflow engine for orchestrating parallel jobs on Kubernetes. Argo
+workflows comes enabled by default with Nebari deployments.
+
+## Accessing Argo Server
+
+If Argo Workflows is enabled, users can access argo workflows server at: `your-nebari-domain.com/argo`. Log in via
+Keycloak with your usual credentials.
+
+## Submitting a Workflow via Argo Server
+
+You can submit a workflow by clicking "SUBMIT NEW WORKFLOW" on the landing page assuming you have the appropriate
+permissions.
+
+![Argo Server Landing Page](../images/argo-server-landing-page.png)
+
+## Submitting a workflow via Argo CLI
+
+You can submit or manage workflows via the Argo CLI. The Argo CLI can be downloaded from the
+[Argo Releases](https://github.com/argoproj/argo-workflows/releases) page. After downloading the CLI, you can get your
+token from the Argo Server UI by clicking on the user tab in the bottom left corner and then clicking "Copy To
+Clipboard". You'll need to make a few edits to access to what was copied for Argo CLI to work correctly. The base href
+should be `ARGO_BASE_HREF=/argo` in the default nebari installation and you need to set the namespace where Argo was
+deployed (dev by default) `ARGO_NAMESPACE=dev`. After setting those variables and the others copied from the Argo Server
+UI, you can check that things are working by running `argo list`.
+
+![Argo Workflows User Tab](../images/argo-workflows-user-tab.png)
+
+## Additional Argo Workflows Resources
+
+Refer to the [Argo documentation](https://argoproj.github.io/argo-workflows/) for further details on Argo Workflows.

nebari/template/stages/07-kubernetes-services/modules/kubernetes/services/argo-workflows/main.tf

@@ -8,16 +8,21 @@ resource "helm_release" "argo-workflows" {
   namespace  = var.namespace
   repository = "https://argoproj.github.io/argo-helm"
   chart      = "argo-workflows"
-  version    = "0.13.1"
+  version    = "0.22.9"
 
   values = concat([
     file("${path.module}/values.yaml"),
-    # https://github.com/argoproj/argo-helm/blob/argo-workflows-0.13.1/charts/argo-workflows/values.yaml
-
 
     jsonencode({
       singleNamespace = true # Restrict Argo to operate only in a single namespace (the namespace of the Helm release)
 
+      workflow = {
+        serviceAccount = {
+          create = true
+          name   = "argo-workflow"
+        }
+      }
+
       controller = {
         metricsConfig = {
           enabled = true # enable prometheus
@@ -28,6 +33,11 @@ resource "helm_release" "argo-workflows" {
         nodeSelector = {
           "${var.node-group.key}" = var.node-group.value
         }
+        workflowDefaults = {
+            spec = {
+              serviceAccountName = "argo-workflow"
+            }
+          }
       }
 
       server = {
@@ -62,9 +72,6 @@ resource "helm_release" "argo-workflows" {
           "${var.node-group.key}" = var.node-group.value
         }
       }
-      controller = {
-        containerRuntimeExecutor = "emissary"
-      }
 
     })
   ], var.overrides)
@@ -180,9 +187,9 @@ resource "kubernetes_cluster_role_binding" "argo-admin-rb" {
   }
 }
 
-resource "kubernetes_service_account" "argo-edit-sa" {
+resource "kubernetes_service_account" "argo-dev-sa" {
   metadata {
-    name      = "argo-edit"
+    name      = "argo-dev"
     namespace = var.namespace
     annotations = {
       "workflows.argoproj.io/rbac-rule" : "'argo_developer' in groups"
@@ -192,9 +199,9 @@ resource "kubernetes_service_account" "argo-edit-sa" {
   }
 }
 
-resource "kubernetes_cluster_role_binding" "argo-edit-rb" {
+resource "kubernetes_cluster_role_binding" "argo-dev-rb" {
   metadata {
-    name = "argo-edit"
+    name = "argo-dev"
   }
 
   role_ref {
@@ -204,10 +211,12 @@ resource "kubernetes_cluster_role_binding" "argo-edit-rb" {
   }
   subject {
     kind      = "ServiceAccount"
-    name      = kubernetes_service_account.argo-edit-sa.metadata.0.name
+    name      = kubernetes_service_account.argo-dev-sa.metadata.0.name
     namespace = var.namespace
   }
 }
+
+
 resource "kubernetes_service_account" "argo-view-sa" {
   metadata {
     name      = "argo-view"

nebari/template/stages/07-kubernetes-services/modules/kubernetes/services/argo-workflows/values.yaml

@@ -1 +1 @@
-# https://github.com/argoproj/argo-helm/blob/argo-workflows-0.13.1/charts/argo-workflows/values.yaml
+# https://github.com/argoproj/argo-helm/blob/argo-workflows-0.22.9/charts/argo-workflows/values.yaml