Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to run jupyter-gallery server in a sidecar container #2590

Closed
wants to merge 1 commit into from

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Jul 28, 2024

Reference Issues or PRs

Closes #2514 - this is the proposed solution (a)

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

To test this feature:

  1. Shut down your Jupyter server
  2. Deploy with the following config in your nebari-config.yaml:
    jupyterlab:
      gallery_settings:
        title: Example repositories
        destination: examples
        run_in_separate_container: true
        exhibits:
        - title: Nebari
          git: https://github.com/nebari-dev/nebari.git
          homepage: https://github.com/nebari-dev/nebari
          description: 🪴 Nebari - your open source data science platform
    default_images:
      jupyterlab: quay.io/nebari/nebari-jupyterlab:jupyterlab-gallery-v0.5.0-72d14e3-20240727
  3. Open a notebook/terminal and execute ls /etc/jupyter
  4. See that jupyyter_gallery_config.json is no longer present (when run_in_separate_container is set to true)

Still to be done

  • update docker image main branch (unless we want a dedicated, smaller docker image):
    • with a new version of jupyter-server-proxy one the PR with SSE streaming support is merged
    • with a new version of jupyterhub once the PR patching **kwargs handling in initalize is merged
    • remove the monkeypatch for the latter from this PR once we can
  • implement (and test) fallback volume mounting for run_in_separate_container=false
  • open a documentation PR against nebari docs
  • add resource limits for the container
  • rename variables and functions
    • preserve_extra_files is too technical, and now it does more than that;
    • etc-jupyter-secret-config-data is correct if we want to treat more config files like that; but then we probably would want to use a more generic name for this container (currently "gallery-sidecar")
    • run_in_separate_container - this is the admin-facing config option; other ideas welcome, e.g. isolate_runtime_and_config
  • reconsider if we can re-enable xsrf token validation (I will write down a separate comment on this one later)

@dcmcand
Copy link
Contributor

dcmcand commented Oct 24, 2024

@krassowski what is the status here? Is it still being worked on?

@krassowski
Copy link
Member Author

krassowski commented Oct 25, 2024

I have some work locally. I would need more time to rebase it on top of the current main. There are no blockers. I am just unable to get enough focus time given the time it takes to deploy/iterate.

@dcmcand
Copy link
Contributor

dcmcand commented Oct 25, 2024

Ok, I am going to close this, but leave the branch, when you have time to work on it, we can open a new PR.

@dcmcand dcmcand closed this Oct 25, 2024
@krassowski
Copy link
Member Author

FYI, GitHub has an annoying UX when PR gets closed and then rebased:

image

@krassowski
Copy link
Member Author

To clarify I just pushed the local changes to make sure they are up, but they will not show up here and the conversation will not be updated. No need to open a new one as I will not get to finalizing it this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: follow-up 📫 Someone needs to get back to this issue or PR
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

Better secret support for PAT, LLM keys, etc
3 participants