Allow to run jupyter-gallery server in a sidecar container #2590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
Closes #2514 - this is the proposed solution (a)
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Any other comments?
To test this feature:
nebari-config.yaml
:ls /etc/jupyter
jupyyter_gallery_config.json
is no longer present (whenrun_in_separate_container
is set totrue
)Still to be done
main
branch (unless we want a dedicated, smaller docker image):jupyter-server-proxy
one the PR with SSE streaming support is merged**kwargs
handling ininitalize
is mergedrun_in_separate_container=false
preserve_extra_files
is too technical, and now it does more than that;etc-jupyter-secret-config-data
is correct if we want to treat more config files like that; but then we probably would want to use a more generic name for this container (currently "gallery-sidecar")run_in_separate_container
- this is the admin-facing config option; other ideas welcome, e.g.isolate_runtime_and_config