Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal RFC] Create RSpec helpers for migrations specs #27

Draft
wants to merge 1 commit into
base: kennyadsl/move-promo-calculator
Choose a base branch
from

Conversation

kennyadsl
Copy link
Member

Description

It will be easier to create new migration tests without too much boilerplate code.

Now that we have a couple of migration specs it's easier to spot what should be extracted into those helpers methods.

I'm hesitant to submit this PR into Solidus for several reasons:

  • I'd like to understand if we can find the previous migration programmatically without the need to set it manually
  • I don't like the clear_tables_cache method. I'd probably prefer to flush all the ActiveRecord tables cache rather than specifying which one we need to reset.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

It will be easier to create new migration tests without
too much boilerplate code.

Now that we have a couple of migration specs it's easier
to spot what should be extracted into there helpers methods.
@kennyadsl kennyadsl self-assigned this Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant