Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPITools #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OpenAPITools #2

wants to merge 1 commit into from

Conversation

neclimdul
Copy link
Owner

Testing OpenAPITools Generator

Copy link
Owner Author

@neclimdul neclimdul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I'm ready to pull the trigger on this. Some of these changes are not positive.

@@ -54,7 +54,7 @@ No authorization required

### HTTP request headers

- **Content-Type**: application/x-www-form-urlencoded
- **Content-Type**: Not defined
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These don't look correct. The spec contains this:

        "consumes": [
          "application/x-www-form-urlencoded"
        ],

@@ -120,7 +124,7 @@ No authorization required
[[Back to top]](#) [[Back to API list]](../../README.md#documentation-for-api-endpoints) [[Back to Model list]](../../README.md#documentation-for-models) [[Back to README]](../../README.md)

# **createEmailTemplateUsingPOST**
> \NecLimDul\MarketoRest\Asset\Model\ResponseOfEmailTemplateResponse createEmailTemplateUsingPOST($create_email_template_request)
> \NecLimDul\MarketoRest\Asset\Model\ResponseOfEmailTemplateResponse createEmailTemplateUsingPOST($name, $folder, $content, $description)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know that these changes are ideal. The new generated code is less like the swagger docs on the Marketo site and even though its a bit more work I would much rather have the object to match the documentation.

This seems to be a feature of some sort in OpenApiTools. Hopefully there's a way to work around it and get the more accurate code.

@neclimdul neclimdul changed the base branch from master to main May 4, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant