Skip to content

Commit

Permalink
Change indentation: 4 -> 2 spaces
Browse files Browse the repository at this point in the history
  • Loading branch information
@necolas
necolas committed Jan 24, 2014
1 parent 68322db commit 45cc401
Show file tree
Hide file tree
Showing 2 changed files with 66 additions and 66 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,6 @@ cutting new releases.
added to the CHANGELOG (inc. date), and the `bower.json`, `component.json`,
and `normalize.css` files.
3. The commit message must be of `v0.0.0` format.
4. Create an annotated tag for the version: `git tag -m "v0.0.0" v0.0.0`.
4. Create an annotated tag for the version: `git tag -m "v0.0.0" 0.0.0`.
5. Push the changes and tags to GitHub: `git push --tags origin master`
6. Checkout the `gh-pages` branch and follow the instructions in the README.
Loading

12 comments on commit 45cc401

@koistya
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@necolas can I ask, why did you change indentation? It is now out of sync with H5BP's CSS coding style..

@andrejsverza
Copy link

@andrejsverza andrejsverza commented on 45cc401 Jan 30, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alrra
Copy link
Contributor

@alrra alrra commented on 45cc401 Jan 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koistya, @drumsibumsi I presume that it's just a personal preference.

@andrejsverza
Copy link

@andrejsverza andrejsverza commented on 45cc401 Jan 30, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koistya
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drumsibumsi heh, everything I work on these days uses 4 spaces, which makes code more readable, but who cares ;)

@andrejsverza
Copy link

@andrejsverza andrejsverza commented on 45cc401 Jan 30, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shirk3y
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's funny because his article stands for 4 spaces instead or 2 :) https://github.com/necolas/idiomatic-css#2-whitespace

@cbracco
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soft tabs with 2 spaces are the only way to ensure code renders the same in every environment, which could be the motivation for the change.

@anEffingChamp
Copy link

@anEffingChamp anEffingChamp commented on 45cc401 Dec 15, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nvartolomei
Copy link

@nvartolomei nvartolomei commented on 45cc401 Dec 15, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FagnerMartinsBrack
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nvartolomei

Can't you do git blame -w -M instead?

Source: https://coderwall.com/p/x8xbnq/git-don-t-blame-people-for-changing-whitespaces-or-moving-code

@nvartolomei
Copy link

@nvartolomei nvartolomei commented on 45cc401 Dec 16, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.