Skip to content

Commit

Permalink
Fix pkg#3 and pkg#4 incomplete and packed refs
Browse files Browse the repository at this point in the history
The original git library dependency (github.com/gogits/git) did not correctly handle refs that have been packed.
Pull request was made to address but appears that repo is no longer in active development.

This PR proposes switching to use the code.gitea.io/git lib (from which the original dependency was forked) as this correctly identifies the tags.
  • Loading branch information
necrophonic authored Oct 12, 2017
1 parent 1863357 commit 3a96e14
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion cmd/tag.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"fmt"
"os/exec"

"code.gitea.io/git"
"github.com/blang/semver"
"github.com/gogits/git"
"github.com/pkg/errors"
Expand Down Expand Up @@ -128,7 +129,7 @@ func init() {
func tag(repo *git.Repository, major, minor, patch uint64) error {

fmt.Printf("Creating v%d.%d.%d\n", major, minor, patch)
id, err := repo.GetCommitIdOfBranch("master")
id, err := repo.GetBranchCommitID("master")
if err != nil {
return errors.Wrap(err, "Unable to get commit ID of branch ")
}
Expand Down

0 comments on commit 3a96e14

Please sign in to comment.