Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microservices Support #38

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

moparlakci
Copy link

@moparlakci moparlakci commented Nov 14, 2022

PR for #37

Hi, can you review the changes, and maybe fix the request injection and request type check if you are more familiar with NestJs and Typescript than me :)
Tests are passing for TCP clients, other clients like RMQ, Websockets, Graphql should pass when the request injection is done better.. The code is there but couldnt plug it together for all of them..

@moparlakci
Copy link
Author

@sandeepsuvit ping

@sandeepsuvit
Copy link
Contributor

Hi @moparlakci thanks for the PR. I see that multiple core methods have been modified in this PR. Hence ill have to review this PR carefully so that the normal workflow isn't affected. Please give me some time to review it since i am currently busy with my other projects. Will update you here after i review it.

@moparlakci
Copy link
Author

@sandeepsuvit okay understandable, thanks. Normally all tests are passing.

@sandeepsuvit sandeepsuvit mentioned this pull request Dec 5, 2022
@ezebrotsky
Copy link

Hi @sandeepsuvit, is it possible to review this PR and merge it if it's working well?

@Robokishan
Copy link

Any update over this. This PR looks good! can you please merge this ?

@jayzernguyenstarack
Copy link

Hi guys just follow up on this. When will this be ready?

@Robokishan
Copy link

I just grab the forked repo for this change. everything is working good in production thanks for fork man! @moparlakci

@moparlakci
Copy link
Author

Hi Guys @Robokishan @jayzernguyenstarack @ezebrotsky
This still needs some improvements, not 100% foolproof.
I'll try to make some time for this, this week.

Have a nice day

@jayzernguyenstarack
Copy link

Hi Guys @Robokishan @jayzernguyenstarack @ezebrotsky This still needs some improvements, not 100% foolproof. I'll try to make some time for this, this week.

Have a nice day

Thanks mate

@manneyugn
Copy link

hello, any update on this, I happened to run into the same use case mentioned in this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants