Use geometries from schematisation for pipe, weir and orifice (#410)

CHANGES.rst

@@ -5,7 +5,7 @@ Changelog of threedigrid-builder
 1.22.1 (unreleased)
 -------------------
 
-- Nothing changed yet.
+- Use pipe.geom, weir.geom and orifice.weir to build gridadmin
 
 
 1.22.0 (2025-01-08)

threedigrid_builder/grid/structures.py

@@ -75,6 +75,7 @@ class WeirOrifice:  # NL: stuw / doorlaat
     zoom_category: int
     display_name: str
     sewerage: int
+    the_geom: shapely.Geometry
 
 
 class WeirOrifices(Array[WeirOrifice]):
@@ -114,6 +115,7 @@ def get_lines(self, connection_nodes, line_id_counter, connection_node_offset=0)
         return Lines(
             id=itertools.islice(line_id_counter, len(self)),
             line=line,
+            line_geometries=self.the_geom,
             content_type=self.content_type,
             content_pk=self.id,
             kcu=self.crest_type,  # implicitly converts CalculationType -> LineType

threedigrid_builder/interface/db.py

@@ -724,6 +724,7 @@ def get_orifices(self) -> Orifices:
             models.Orifice.discharge_coefficient_positive,
             models.Orifice.display_name,
             models.Orifice.sewerage,
+            models.Orifice.geom.label("the_geom"),
             case(
                 {
                     models.Orifice.friction_value.isnot(None)
@@ -754,6 +755,7 @@ def get_orifices(self) -> Orifices:
             )
         # map friction_type 4 to friction_type 2 to match crosssectionlocation enum
         arr["friction_type"][arr["friction_type"] == 4] = 2
+        arr["the_geom"] = self.reproject(arr["the_geom"])
 
         return Orifices(**{name: arr[name] for name in arr.dtype.names})
 
@@ -774,6 +776,7 @@ def get_pipes(self) -> Pipes:
             models.Pipe.hydraulic_conductivity_out,
             models.Pipe.hydraulic_conductivity_in,
             models.Pipe.material_id.label("material"),
+            models.Pipe.geom.label("the_geom"),
             case(
                 {
                     models.Pipe.friction_value.isnot(None)
@@ -803,6 +806,7 @@ def get_pipes(self) -> Pipes:
         arr["friction_type"][arr["friction_type"] == 4] = 2
         arr["hydraulic_conductivity_out"] /= DAY_IN_SECONDS
         arr["hydraulic_conductivity_in"] /= DAY_IN_SECONDS
+        arr["the_geom"] = self.reproject(arr["the_geom"])
 
         # transform to a Pipes object
         return Pipes(**{name: arr[name] for name in arr.dtype.names})
@@ -848,6 +852,7 @@ def get_weirs(self) -> Weirs:
             models.Weir.discharge_coefficient_positive,
             models.Weir.display_name,
             models.Weir.sewerage,
+            models.Weir.geom.label("the_geom"),
             case(
                 {
                     models.Weir.friction_value.isnot(None)
@@ -874,6 +879,7 @@ def get_weirs(self) -> Weirs:
             )
         # map friction_type 4 to friction_type 2 to match crosssectionlocation enum
         arr["friction_type"][arr["friction_type"] == 4] = 2
+        arr["the_geom"] = self.reproject(arr["the_geom"])
 
         return Weirs(**{name: arr[name] for name in arr.dtype.names})
 

threedigrid_builder/tests/test_db.py

@@ -234,6 +234,11 @@ def test_get_pipes(db):
     assert pipes.friction_type[28] == FrictionType.MANNING
     assert pipes.friction_value[36] == 0.0145
     assert pipes.display_name[33] == "71518_71517"
+    assert_geometries_equal(
+        pipes.the_geom[0],
+        shapely.from_wkt("LINESTRING (110267.3 517868.8, 110264.3 517863.5)"),
+        tolerance=1,
+    )
 
 
 def test_get_settings(db):
@@ -379,6 +384,11 @@ def test_get_weirs(db):
     assert weirs.friction_value[36] == 0.03
     assert weirs.display_name[33] == "KST-JL-76"
     assert weirs.sewerage[0] == 1
+    assert_geometries_equal(
+        weirs.the_geom[0],
+        shapely.from_wkt("LINESTRING (110278.3 517669.1, 110276.3 517669.8)"),
+        tolerance=1,
+    )
 
 
 def test_get_dem_average(db):