Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geopackage support #350

Merged
merged 12 commits into from
Mar 12, 2024
Merged

geopackage support #350

merged 12 commits into from
Mar 12, 2024

Conversation

margrietpalm
Copy link
Contributor

@margrietpalm margrietpalm commented Feb 13, 2024 •
edited
Loading

  • Add geopackage schematisation to test data
  • Use geopackage, instead of spatialite, for tests
  • Add geopackage to schematisations tested in integration test

Currently using threedi-schema==0.219.2.dev1. I will change that once nens/threedi-schema#55 is merged and a new threedi-schema is released.

@margrietpalm margrietpalm changed the title WIP geopackage support geopackage support Feb 26, 2024
jpprins1
jpprins1 approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@jpprins1 jpprins1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Note: might need to change package numbers if threedi-schema is released as (non-beta) to PyPi.

@margrietpalm margrietpalm merged commit 59bcc47 into master Mar 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpprins1 jpprins1 jpprins1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@margrietpalm @jpprins1