[WIP] Create quarter administration #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daanvaningen
reviewed
May 6, 2024
| @@ -78,7 +78,7 @@ subroutine set_2d_computational_nodes_lines(origin, lgrmin, kmax, mmax, nmax, dx | |||
| deallocate(area_mask_padded) | |||
| endif | |||
| write(*,*) '** INFO: Number of 2D nodes is: ', nod - 1 | |||
| write(*,*) '** INFO: Number of 2D lines is: ', l_u + l_v | |||
| write(*,*) '** INFO: Number of 2D lines is: ', l_u + (l_v - l_u) | |||
daanvaningen
reviewed
May 6, 2024
Comment on lines
+271
to
+281
| if (ku==kd) then | ||
| quarter_line(get_quarter_idx(nodd, 2), 1) = l - 1 ! This needs to be an index in Python again. | ||
| quarter_line(get_quarter_idx(nodd, 4), 1) = l - 1 | ||
| quarter_line(get_quarter_idx(nodu, 1), 1) = l - 1 | ||
| quarter_line(get_quarter_idx(nodu, 3), 1) = l - 1 | ||
| quarter_neighbour(get_quarter_idx(nodd, 2), 1) = nodu - 1 | ||
| quarter_neighbour(get_quarter_idx(nodd, 4), 1) = nodu - 1 | ||
| quarter_neighbour(get_quarter_idx(nodu, 1), 1) = nodd - 1 | ||
| quarter_neighbour(get_quarter_idx(nodu, 3), 1) = nodd - 1 | ||
| elseif (ku == kd + 1) then | ||
| if (nd == 2 * nu - 1) then |
There was a problem hiding this comment.
Some comments here explaining the logic would be nice I think.
Suggested change
| if (ku==kd) then | |
| quarter_line(get_quarter_idx(nodd, 2), 1) = l - 1 ! This needs to be an index in Python again. | |
| quarter_line(get_quarter_idx(nodd, 4), 1) = l - 1 | |
| quarter_line(get_quarter_idx(nodu, 1), 1) = l - 1 | |
| quarter_line(get_quarter_idx(nodu, 3), 1) = l - 1 | |
| quarter_neighbour(get_quarter_idx(nodd, 2), 1) = nodu - 1 | |
| quarter_neighbour(get_quarter_idx(nodd, 4), 1) = nodu - 1 | |
| quarter_neighbour(get_quarter_idx(nodu, 1), 1) = nodd - 1 | |
| quarter_neighbour(get_quarter_idx(nodu, 3), 1) = nodd - 1 | |
| elseif (ku == kd + 1) then | |
| if (nd == 2 * nu - 1) then | |
| if (ku==kd) then | |
| ! ? | |
| quarter_line(get_quarter_idx(nodd, 2), 1) = l - 1 ! This needs to be an index in Python again. | |
| quarter_line(get_quarter_idx(nodd, 4), 1) = l - 1 | |
| quarter_line(get_quarter_idx(nodu, 1), 1) = l - 1 | |
| quarter_line(get_quarter_idx(nodu, 3), 1) = l - 1 | |
| quarter_neighbour(get_quarter_idx(nodd, 2), 1) = nodu - 1 | |
| quarter_neighbour(get_quarter_idx(nodd, 4), 1) = nodu - 1 | |
| quarter_neighbour(get_quarter_idx(nodu, 1), 1) = nodd - 1 | |
| quarter_neighbour(get_quarter_idx(nodu, 3), 1) = nodd - 1 | |
| elseif (ku == kd + 1) then | |
| if (nd == 2 * nu - 1) then | |
| ! ? |
daanvaningen
reviewed
May 6, 2024
threedigrid_builder/application.py
Outdated
| @@ -225,6 +228,7 @@ def make_gridadmin( | |||
| progress_callback: Optional[Callable[[float, str], None]] = None, | |||
| upgrade: bool = False, | |||
| convert_to_geopackage: bool = False, | |||
| create_triangulation: bool = False, | |||
daanvaningen
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.