-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtime secure random number for N3 #670
Conversation
# Conflicts: # src/DBFTPlugin/Consensus/ConsensusContext.MakePayload.cs # src/DBFTPlugin/Consensus/ConsensusContext.cs # src/DBFTPlugin/Consensus/ConsensusService.Check.cs # src/DBFTPlugin/Consensus/ConsensusService.OnMessage.cs # src/DBFTPlugin/Consensus/ConsensusService.cs
…to secure-random * 'secure-random' of github.com:Liaojinghui/neo-modules:
Transaction list exchange will have serious performance consequences. And the worst thing is that it would affect the performance most exactly when we need it most, under some stress, because transaction pressure tends to lead to a greater deal of unsynchrony between the nodes. Notice also that for high-performing networks (which inevitably have to allow tens of thousands of transactions in a block) that could easily mean exchanging 1MB+ messages in this phase further complicating the situation. I'd suggest trying this in neo-bench, four CNs and especially 7+2 scenario. 7+2 was added quite recently and it makes all nodes look bad because the network becomes highly unsynchronized, but that's exactly what makes this case more realistic and interesting (we've not optimized for it yet). |
@roman-khimov Thank you very much for your suggestion roman, that would be a great help. |
* init * upgrade neo * useDiagnostic * Update RpcServer.SmartContract.cs * invoke tree * add event * Add storage changes * Update nuget * rename event state * Unify * update neofs * fix json Co-authored-by: Shargon <[email protected]> Co-authored-by: Erik Zhang <[email protected]> Co-authored-by: Owen Zhang <[email protected]>
* add in file copyright * fix the copyright * update copyright start year * Delete copyright.sh * Delete copyright.txt Co-authored-by: Owen Zhang <[email protected]> Co-authored-by: Erik Zhang <[email protected]>
* init * refac Co-authored-by: Shargon <[email protected]>
* add log when exception happens under debug mode (#686) * Revert "add log when exception happens under debug mode (#686)" (#689) This reverts commit 7b661e5. * Prevent SSRF * Update OracleHttpsProtocol.cs * remove goto * Remove redundant code * Remove empty line Co-authored-by: Jinghui Liao <[email protected]> Co-authored-by: Owen Zhang <[email protected]> Co-authored-by: Erik Zhang <[email protected]>
* add log when exception happens under debug mode (#686) * Revert "add log when exception happens under debug mode (#686)" (#689) This reverts commit 7b661e5. * limit free gas * update limit Co-authored-by: Jinghui Liao <[email protected]> Co-authored-by: Owen Zhang <[email protected]> Co-authored-by: Shargon <[email protected]>
Co-authored-by: Owen Zhang <[email protected]>
Follow ExecFeeFactor changes for MaxBlockSystemFee and make it possible to fit 5K transactions into the block. Related to neo-project/neo-node#850. Co-authored-by: Owen Zhang <[email protected]>
This pr implement secure random number for N3 at runtime.
#601
#637
#596
neo-project/neo#2504