Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completes CYPHER 25 if the feature flag is enabled #351

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ncordon
Copy link
Collaborator

@ncordon ncordon commented Feb 6, 2025

We want to get the CYPHER 25 completion if the corresponding feature flag is enabled

Copy link
Collaborator

@anderson4j anderson4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some spelling stuff for a variable name and one of the test names that could use a quick fix, but logic LGTM

const query = 'CYPHER ';
const cyphe25Enabled = _internalFeatureFlags.cypher25;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cyphe -> cypher on "cyphe25Enabled" (here and the other places where the same name is used)


test('Correctly completes CYPHER when keyword is not finished, optionally with version, when cypher25 is enabled', () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enabled -> disabled here

Copy link

changeset-bot bot commented Feb 12, 2025

⚠️ No Changeset found

Latest commit: 77b1ec8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants