-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New connector #21
New connector #21
Conversation
e1ee56d
to
0954ecc
Compare
Signed-off-by: Ali Ince <[email protected]>
Looks like you've updated the documentation! Check out your changes at https://neo4j-docs-kafka-connector-21.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some early feedback. I need more time for the longer files.
@@ -4,6 +4,6 @@ Neo4j supports the Confluent Cloud with the Neo4j Connector for Confluent runnin | |||
Confluent's Custom Connectors provide a way to extend the Confluent Cloud beyond the fully managed connectors available on their platform. | |||
|
|||
Custom Connectors are Kafka Connect plugins created by users, modified open-source connector plugins, or third-party connector plugins like the Neo4j Connector for Confluent. | |||
Find out more about Custom Connectors in the link:https://docs.confluent.io/cloud/current/connectors/bring-your-connector/overview.html[Confluent documentation]. | |||
Find out more about Custom Connectors in the link:https://docs.confluent.io/cloud/current/connectors/bring-your-connector/overview.html[Confluent documentation] and read our link:https://neo4j.com/developer-blog/confluent-cloud-neo4j-auradb-connector-2[blog post] which includes a worked example on how to set this up with Aura. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually prefer not to refer to blog posts due to their being time-bound. Is there a doc resource we could use instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, this scenario is not covered in our documentation yet.
|
||
The Neo4j Connector for Confluent runs as a **Kafka Connect Plugin** on the Confluent Platform and can be deployed into the Confluent Cloud using their Custom Connectors. | ||
It is available from the link:https://www.confluent.io/hub/neo4j/kafka-connect-neo4j[Confluent Hub], or from the link:https://neo4j.com/download-center[Neo4j Download Center]. | ||
The connector provides a sink component, which consumes messages from Apache Kafka topics and applies configured changes into a Neo4j or Aura database. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like some content is missing here? I suppose something like "The archive downloaded from ... contains ..." or a link to GitHub here or in the Distribution section, as otherwise I can't see any references on how to obtain these files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, since we are in EAP, we explicitly removed references to resources to be downloaded. They'll need to get the files manually from us.
Co-authored-by: Nicola Vitucci <[email protected]>
Rename sink properties to make them more consistent with the source
@nvitucci I'd suggest us to close this PR and continue working on it in it's own branch, i.e. |
Yes, I think it's the easier option. |
closing this PR for now - we'll continue updating the docs in the |
actually I renamed the branch to |
No description provided.