Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New connector #21

Closed
wants to merge 43 commits into from
Closed

New connector #21

wants to merge 43 commits into from

Conversation

fbiville
Copy link
Contributor

No description provided.

@ali-ince ali-ince marked this pull request as ready for review November 21, 2023 15:11
@neo-technology-commit-status-publisher
Copy link
Collaborator

Looks like you've updated the documentation!

Check out your changes at https://neo4j-docs-kafka-connector-21.surge.sh

Copy link
Contributor

@nvitucci nvitucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some early feedback. I need more time for the longer files.

@@ -4,6 +4,6 @@ Neo4j supports the Confluent Cloud with the Neo4j Connector for Confluent runnin
Confluent's Custom Connectors provide a way to extend the Confluent Cloud beyond the fully managed connectors available on their platform.

Custom Connectors are Kafka Connect plugins created by users, modified open-source connector plugins, or third-party connector plugins like the Neo4j Connector for Confluent.
Find out more about Custom Connectors in the link:https://docs.confluent.io/cloud/current/connectors/bring-your-connector/overview.html[Confluent documentation].
Find out more about Custom Connectors in the link:https://docs.confluent.io/cloud/current/connectors/bring-your-connector/overview.html[Confluent documentation] and read our link:https://neo4j.com/developer-blog/confluent-cloud-neo4j-auradb-connector-2[blog post] which includes a worked example on how to set this up with Aura.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually prefer not to refer to blog posts due to their being time-bound. Is there a doc resource we could use instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, this scenario is not covered in our documentation yet.

modules/ROOT/pages/overview.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/overview.adoc Outdated Show resolved Hide resolved

The Neo4j Connector for Confluent runs as a **Kafka Connect Plugin** on the Confluent Platform and can be deployed into the Confluent Cloud using their Custom Connectors.
It is available from the link:https://www.confluent.io/hub/neo4j/kafka-connect-neo4j[Confluent Hub], or from the link:https://neo4j.com/download-center[Neo4j Download Center].
The connector provides a sink component, which consumes messages from Apache Kafka topics and applies configured changes into a Neo4j or Aura database.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like some content is missing here? I suppose something like "The archive downloaded from ... contains ..." or a link to GitHub here or in the Distribution section, as otherwise I can't see any references on how to obtain these files.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, since we are in EAP, we explicitly removed references to resources to be downloaded. They'll need to get the files manually from us.

modules/ROOT/partials/sink-kafka-config.adoc Outdated Show resolved Hide resolved
modules/ROOT/partials/sink-dlq-config.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/overview.adoc Outdated Show resolved Hide resolved
@fbiville fbiville requested a review from nvitucci January 4, 2024 16:51
Rename sink properties to make them more consistent with the source
@ali-ince
Copy link
Contributor

ali-ince commented Jan 9, 2024

@nvitucci I'd suggest us to close this PR and continue working on it in it's own branch, i.e. new-connector branch.

@nvitucci
Copy link
Contributor

nvitucci commented Jan 9, 2024

@nvitucci I'd suggest us to close this PR and continue working on it in it's own branch, i.e. new-connector branch.

Yes, I think it's the easier option.

@ali-ince
Copy link
Contributor

ali-ince commented Jan 9, 2024

closing this PR for now - we'll continue updating the docs in the new-connector branch where the new content resides.

@ali-ince ali-ince closed this Jan 9, 2024
@ali-ince ali-ince deleted the new-connector branch January 9, 2024 16:21
@ali-ince
Copy link
Contributor

ali-ince commented Jan 9, 2024

actually I renamed the branch to 5.1-wip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants