Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.1] Add event for registering atlases for use with Material #1581

Open
wants to merge 3 commits into
base: 1.21.1
Choose a base branch
from

Conversation

XFactHD
Copy link
Member

@XFactHD XFactHD commented Oct 4, 2024

This PR adds an event to allow registering texture atlases for inclusion in the AtlasSet held by the ModelManager such that the atlas can be used with Material and other systems that use Minecraft#getTextureAtlas() or ModelManager#getAtlas() to access it.
This is useful for things like using an atlas for an entity-style model like vanilla does for chests, beds, signs and shulkers.

@XFactHD XFactHD added enhancement New (or improvement to existing) feature or request rendering Related to rendering 1.21.1 Targeted at Minecraft 1.21.1 labels Oct 4, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Oct 4, 2024

  • Publish PR to GitHub Packages

Last commit published: d04f4200531f1c6aa550eea38dcd067234295e82.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1581' // https://github.com/neoforged/NeoForge/pull/1581
        url 'https://prmaven.neoforged.net/NeoForge/pr1581'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1581.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1581
cd NeoForge-pr1581
curl -L https://prmaven.neoforged.net/NeoForge/pr1581/net/neoforged/neoforge/21.1.76-pr-1581-material_atlas/mdk-pr1581.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@XFactHD XFactHD requested a review from embeddedt October 8, 2024 16:07
@XFactHD XFactHD changed the base branch from 1.21.x to 1.21.1 October 23, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.1 Targeted at Minecraft 1.21.1 enhancement New (or improvement to existing) feature or request rendering Related to rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants