Complete coverage to 100%

neon-sunset · Aug 12, 2022 · 8d6f42b · 8d6f42b
1 parent 2248bda
commit 8d6f42b
Show file tree

Hide file tree

Showing 5 changed files with 83 additions and 9 deletions.
diff --git a/RangeExtensions.Tests/RangeEnumerable.ICollection.cs b/RangeExtensions.Tests/RangeEnumerable.ICollection.cs
@@ -79,12 +79,47 @@ static int[] CopyCollection<TCollection>(int index, TCollection collection)
         }
     }
 
+#if !NET48
+    [Theory, MemberData(nameof(ValidRangePairs))]
+    public void CopyToSpan_MatchesICollectionCopyTo(Range range, IEnumerable<int> enumerable)
+    {
+        var numbersArray = enumerable.ToArray();
+
+        static int[] CopyCollection<TCollection>(int index, TCollection collection)
+            where TCollection : ICollection<int>
+        {
+            var numbers = new int[collection.Count];
+
+            collection.CopyTo(numbers, index);
+
+            return numbers;
+        }
+
+        static int[] CopySpan(int index, RangeEnumerable rangeCollection)
+        {
+            var numbers = new int[rangeCollection.Count];
+
+            rangeCollection.CopyTo(numbers.AsSpan(), index);
+
+            return numbers;
+        }
+
+        foreach (var index in Data.Indexes(numbersArray))
+        {
+            AssertHelpers.EqualSequenceOrException(
+                () => CopyCollection(index, numbersArray),
+                () => CopySpan(index, range),
+                allowInherited: true);
+        }
+    }
+#endif
+
     [Fact]
     public void Remove_ThrowsNotSupportedException()
     {
         static void Remove()
         {
-            (..100).AsEnumerable().Remove(10);
+            _ = (..100).AsEnumerable().Remove(10);
         }
 
         Assert.Throws<NotSupportedException>(Remove);

diff --git a/RangeExtensions.Tests/RangeEnumerable.IEnumerable.cs b/RangeExtensions.Tests/RangeEnumerable.IEnumerable.cs
@@ -31,4 +31,18 @@ IEnumerable<int> EnumerateBoxed()
 
         Assert.Equal(enumerable, EnumerateBoxed());
     }
+
+    [Theory, MemberData(nameof(ValidRangePairs))]
+    public void RangeEnumerableBoxedGeneric_MatchesStandardEnumerableRange(Range range, IEnumerable<int> enumerable)
+    {
+        IEnumerable<int> EnumerateBoxed()
+        {
+            foreach (var i in (IEnumerable<int>)range.AsEnumerable())
+            {
+                yield return i;
+            }
+        }
+
+        Assert.Equal(enumerable, EnumerateBoxed());
+    }
 }
diff --git a/RangeExtensions.Tests/RangeEnumerable.cs b/RangeExtensions.Tests/RangeEnumerable.cs
@@ -5,15 +5,13 @@ public partial class RangeEnumerableTests
     public static IEnumerable<object[]> ValidRangePairs() => Data.ValidRangePairs();
     public static IEnumerable<object[]> InvalidRanges() => Data.InvalidRanges();
 
-    [Theory]
-    [MemberData(nameof(ValidRangePairs))]
+    [Theory, MemberData(nameof(ValidRangePairs))]
     public void RangeEnumerable_MatchesStandardEnumerableRange(Range range, IEnumerable<int> enumerable)
     {
         Assert.Equal(enumerable, range.AsEnumerable());
     }
 
-    [Theory]
-    [MemberData(nameof(InvalidRanges))]
+    [Theory, MemberData(nameof(InvalidRanges))]
     public void RangeEnumerable_ThrowsOnInvalidRange(Range range)
     {
         void AsEnumerable()
@@ -24,8 +22,7 @@ void AsEnumerable()
         Assert.Throws<ArgumentOutOfRangeException>(AsEnumerable);
     }
 
-    [Theory]
-    [MemberData(nameof(InvalidRanges))]
+    [Theory, MemberData(nameof(InvalidRanges))]
     public void RangeEnumerator_ThrowsOnInvalidRange(Range range)
     {
         void Enumerate()
@@ -46,4 +43,33 @@ static void Reset()
 
         Assert.Throws<NotSupportedException>(Reset);
     }
+
+    [Theory, MemberData(nameof(ValidRangePairs))]
+    public void RangeEnumerable_ImplicitConversionToRange_KeepsRangeIntact(Range range, IEnumerable<int> enumerable)
+    {
+        _ = enumerable;
+        var rangeEnumerable = range.AsEnumerable();
+
+        Assert.Equal<Range>(range, rangeEnumerable);
+    }
+
+    [Theory, MemberData(nameof(ValidRangePairs))]
+    public void RangeEnumerable_ImplicitConversionFromRange_KeepsRangeIntact(Range range, IEnumerable<int> enumerable)
+    {
+        _ = enumerable;
+        var rangeEnumerable = range.AsEnumerable();
+
+        Assert.Equal<RangeEnumerable>(rangeEnumerable, range);
+    }
+
+    [Theory, MemberData(nameof(InvalidRanges))]
+    public void RangeEnumerable_ImplicitConverstionFromRange_ThrowsOnInvalidRange(Range range)
+    {
+        void ToRangeEnumerable()
+        {
+            RangeEnumerable _ = range;
+        }
+
+        Assert.Throws<ArgumentOutOfRangeException>(ToRangeEnumerable);
+    }
 }
diff --git a/RangeExtensions.Tests/RangeEnumerableExtensions.cs b/RangeExtensions.Tests/RangeEnumerableExtensions.cs
@@ -221,7 +221,6 @@ static void Sum()
         Assert.Throws<OverflowException>(Sum);
     }
 
-
     [Theory]
     [MemberData(nameof(ValidRangePairs))]
     public void Take_MatchesIEnumerableTake(Range range, IEnumerable<int> enumerable)

diff --git a/RangeExtensions.Tests/RangeExtensions.cs b/RangeExtensions.Tests/RangeExtensions.cs
@@ -53,7 +53,7 @@ public void CopyToSpan_DoesNotRunPastRangeCount(Range range, IEnumerable<int> en
     [Fact]
     public void CopyToSpan_ThrowsOnRangeLongerThanSpan()
     {
-        void CopyToSpan()
+        static void CopyToSpan()
         {
             var span = (stackalloc int[128]);