Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix types to use module augmentation instead of @ts-ignore #116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andyjy
Copy link
Contributor

@andyjy andyjy commented Nov 6, 2024

Hi @pffigueiredo - this PR shows how to use module type augmentation to prevent the requirement for @ts-ignore throughout.

Just a suggestion - perhaps not huge benefit given the need to add (+ maintain?!) more detailed type declarations for the pg internals.

But it can bring some benefits e.g. exposes the actual type of types: CustomTypesConfig where it was previously any

@andyjy
Copy link
Contributor Author

andyjy commented Feb 11, 2025

@jawj would you like me to update this PR for the refactor that just landed?

If not then it can be closed - was just a few extra minutes work while working on a previous issue. I'd suggest on balance it's probably worth the additional type safety but fair to consider it mostly a stylistic choice for y'all.

@jawj
Copy link
Collaborator

jawj commented Feb 13, 2025

Hi @andyjy. Yes, please do update in the light of the refactor, and thanks for doing this. It's a definite improvement! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants