TASK: Add documentation how work with psr responses in controller #3444
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some confusion how to replace
$this->response
when modifying view results.The suggested pattern now is more explicit instead of providing any form of helper like:
Instead this will be written explicitly:
Also this change inlines
ActionController::renderView
as the method signature is now really odd and unusable or understandable from the outside.$this->view
should instead be used instead like when also assigning variables.Related changes that lead to the new patterns:
ViewInterface
returns PSRStreamInterface
#3286Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions