Update Node.js version used by CI (#198)

* chore(ci): remove node v12 and v18 to CI

* chore(ci): update actions used in CI

* fix(ci): fix nvim directory was renamed for macOS

* fix(test): fix checking window height broken due to Neovim upgrade

.github/workflows/ci.yml

@@ -14,7 +14,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: ['12', '14', '16']
+        node: ['14', '16', '18']
         os: ['ubuntu-latest', 'macos-11', 'windows-latest']
         include:
         - os: ubuntu-latest
@@ -23,7 +23,7 @@ jobs:
           EXTRACT: tar xzf
         - os: macos-11
           NIGHTLY: nvim-macos.tar.gz
-          NVIM_BIN_PATH: nvim-osx64/bin
+          NVIM_BIN_PATH: nvim-macos/bin
           EXTRACT: tar xzf
         - os: windows-latest
           NIGHTLY: nvim-win64.zip
@@ -34,7 +34,7 @@ jobs:
 
     # Steps represent a sequence of tasks that will be executed as part of the job
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
 
     - uses: actions/setup-node@v3
       with:
@@ -76,7 +76,7 @@ jobs:
 
         npm run test-build --stream
 
-    - uses: codecov/codecov-action@v2
+    - uses: codecov/codecov-action@v3
       if: runner.os == 'macOS'
       with:
         verbose: true # optional (default = false)

packages/neovim/src/api/Window.test.ts

@@ -89,9 +89,7 @@ describe('Window API', () => {
     it('has correct height after ":split"', async () => {
       const currentHeight = await win.height;
       await nvim.command('split');
-      // XXX: Not sure if this is correct, but guessing after a split we lose a row
-      // due to status bar?
-      expect(await win.height).toEqual(Math.floor(currentHeight / 2) - 1);
+      expect(await win.height).toEqual(Math.floor(currentHeight / 2));
 
       win.height = 5;
       expect(await win.height).toEqual(5);