fix: remove validation from configs.lua #3584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suppose we could keep the old syntax for the validation and do a reverse version check, aka only validate if neovim is less than v0.11 but don't know how much we'd gain from that. |
glepnir
approved these changes
Jan 23, 2025
This is because using the old syntax for vim.validate causes `:checkhealth vim.deprecated` to be flooded with deprecated messages. It would also be possible to do a version check and use the newer syntax for vim.validate, but since configs.lua will be replaced by vim.lsp.config in the future there is little need to future-proof it. Closes neovim#3583.
dundargoc
force-pushed
the
fix/vim.validate
branch
from
4571f91 to
0729fac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because using the old syntax for vim.validate causes
:checkhealth vim.deprecatedto be flooded with deprecated messages.It would also be possible to do a version check and use the newer syntax
for vim.validate, but since configs.lua will be replaced by
vim.lsp.config in the future there is little need to future-proof it.
Closes #3583.