Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Function CR refs #182

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

efiacor
Copy link
Contributor

@efiacor efiacor commented Nov 11, 2024

The Function CRD and Repo content tyoe has been removed from Porch. This cleans up any remaining refs.

Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit da49ce0
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/67320fd4895c960008908bcc
😎 Deploy Preview https://deploy-preview-182--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@kushnaidu kushnaidu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo in the PR title else everything looks good to me.

@efiacor efiacor changed the title Remove Fucntion CR refs Remove Function CR refs Nov 11, 2024
@efiacor
Copy link
Contributor Author

efiacor commented Nov 11, 2024

/restest

@Catalin-Stratulat-Ericsson
Copy link
Contributor

/retest

@Catalin-Stratulat-Ericsson
Copy link
Contributor

/approve looks good to me apart from the weird test behavior.

@CsatariGergely
Copy link
Contributor

We can ignore the reviewdog job result so far. It is fixed in #176 what requires the merger of #179

@kispaljr
Copy link
Contributor

/lgtm

@nephio-prow nephio-prow bot removed the lgtm label Nov 11, 2024
Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Contributor

nephio-prow bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Catalin-Stratulat-Ericsson, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Nov 14, 2024
@liamfallon
Copy link
Member

/retest

1 similar comment
@efiacor
Copy link
Contributor Author

efiacor commented Nov 14, 2024

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants