Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual CodeQL configuration to mitigate tide merging problems #734

Merged
merged 1 commit into from
May 15, 2024

Conversation

radoslawc
Copy link
Contributor

CodeQL default setup has been causing problems by not recognising golang, adding manual configuration.

@nephio-prow nephio-prow bot requested review from henderiw and tliron May 14, 2024 11:40
@radoslawc radoslawc closed this May 14, 2024
@radoslawc radoslawc reopened this May 14, 2024
@radoslawc
Copy link
Contributor Author

@tliron @henderiw this will have to be merged manually since 'old' codeql is hanging there, but the one with manual configuration has passed.

@radoslawc
Copy link
Contributor Author

/override "Code scanning results / CodeQL"

Copy link
Contributor

nephio-prow bot commented May 14, 2024

@radoslawc: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Code scanning results / CodeQL

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • presubmit-nephio-fossology
  • presubmit-nephio-license-header-check
  • presubmit-nephio-scancode-toolkit
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Code scanning results / CodeQL"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liamfallon
Copy link
Member

/lgtm
/approve

Copy link
Contributor

nephio-prow bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label May 15, 2024
@radoslawc radoslawc merged commit fa7cb64 into nephio-project:main May 15, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants