-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update porch dependencies to nephio porch modules #781
Conversation
/retest |
/override presubmit-nephio-lichen |
@radoslawc: Overrode contexts on behalf of radoslawc: presubmit-nephio-lichen In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
changes look good and unit tests are all green on my machine /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test presubmit-nephio-golangci-lint |
/test presubmit-nephio-lichen |
I could not test but overall |
#779
Main change here was to remove the use of the replace directive for porch in the go.mod files.
Update the import paths.
Minor code updates.
Update the other dependencies to satisfy the existing codebase.