-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
O2-IMS Operator #844
base: main
Are you sure you want to change the base?
O2-IMS Operator #844
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Skipping CI for Draft Pull Request. |
a81c6f0
to
9174461
Compare
9174461
to
6e47127
Compare
6e47127
to
cf1a021
Compare
Co-authored-by: Sagar Arora <[email protected]> Co-authored-by: Vishwanath Jayaraman <[email protected]> Signed-off-by: Daniel Kostecki <[email protected]> Signed-off-by: Sagar Arora <[email protected]> Signed-off-by: Vishwanath Jayaraman <[email protected]>
Co-authored-by: Sagar Arora <[email protected]> Co-authored-by: Vishwanath Jayaraman <[email protected]> Signed-off-by: Daniel Kostecki <[email protected]> Signed-off-by: Vishwanath Jayaraman <[email protected]> Signed-off-by: Sagar Arora <[email protected]>
cf1a021
to
670c826
Compare
Changed provisionedResources to provisionedResourceSet (NOTE: This requires the updated CRD in the api repo) Removed cluster constants from templateParameters, moved to constants in manager.py using kopf.Memo Co-authored-by: Sagar Arora <[email protected]> Co-authored-by: Vishwanath Jayaraman <[email protected]> Signed-off-by: Daniel Kostecki <[email protected]> Signed-off-by: Vishwanath Jayaraman <[email protected]> Signed-off-by: Sagar Arora <[email protected]>
37d4f68
to
c052e16
Compare
# limitations under the License. | ||
########################################################################## | ||
|
||
from utils import LOG_LEVEL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used below the LOG_LEVEL. In line 32 for example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be coming from the utils module
operators/o2ims-operator/controllers/provisioning_request_validation_controller.py
Show resolved
Hide resolved
#### Non-containerized Development Environment | ||
|
||
```bash | ||
kubectl exec -it -n porch-system porch-sa-test -- cat /var/run/secrets/kubernetes.io/serviceaccount/token &> /tmp/porch-token |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure this doesn't exist. Only if we use the script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry true! There is one step less we have to create
kubectl -f tests/deployment/sa-test-pod.yaml
then porch-sa-test will exist.
Push this image in your cluster, here we are using a `kind` cluster so we will push using the below command: | ||
|
||
```bash | ||
kind load docker-image o2ims:latest -n mgmt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to drop the "-n mgmt" on sandbox env.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay good to know this is helpful when we have multiple clusters.
We can mention this separately.
Updates to README for unit tests init to make controllers and tests modules Updates to utils as a result of testing test_utils PyTest unit tests, as well as accompanying requirements Co-authored-by: Sagar Arora <[email protected]> Co-authored-by: Vishwanath Jayaraman <[email protected]>
kubectl exec -it -n porch-system porch-sa-test -- cat /var/run/secrets/kubernetes.io/serviceaccount/token &> /tmp/porch-token | ||
|
||
# Create CRD | ||
kubectl create -f "$(dirname "$0")"/../config/crd/bases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would need to change to maybe
kubectl create -f https://raw.githubusercontent.com/nephio-project/api/refs/heads/main/config/crd/bases/o2ims.provisioning.oran.org_provisioningrequests.yaml
as the ../config/crd/bases is not present
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that is true
7c253aa
to
e7351b8
Compare
Co-authored-by: Daniel Kostecki <[email protected]> Co-authored-by: Sagar Arora <[email protected]> Co-authored-by: Vishwanath Jayaraman <[email protected]>
e7351b8
to
397a7c8
Compare
A PR creating a O2-IMS Operator, including related management code, controllers, utilities, testing code, and documentation.
closes: #759
closes: #757
Update 02-03-2025: Now relies on nephio-project/api#66
This API update is because of a previous outdated field in the CRD, to test this before it is merged one must use the link to the CRD from that commit in the curl step of the README.