Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise caching strategy (PR-8) manual rebase #135

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

liamfallon
Copy link
Member

@liamfallon liamfallon commented Nov 11, 2024

This PR is a manual merge of #8, created to test the performance of the current main branch (and its improvements) against the strategy in PR#8.

This PR is not suggested for merging, rather to try out the solution in PR#8, given that the main branch has moved on too much to make rebasing of PR#8 practical.

@nephio-prow nephio-prow bot requested review from efiacor and s3wong November 11, 2024 15:33
Copy link
Contributor

nephio-prow bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Nov 11, 2024
@liamfallon liamfallon changed the title Revise caching strategy (PR-8) manual merge Revise caching strategy (PR-8) manual rebase Nov 11, 2024
@liamfallon
Copy link
Member Author

/test presubmit-nephio-go-test

2 similar comments
@liamfallon
Copy link
Member Author

/test presubmit-nephio-go-test

@liamfallon
Copy link
Member Author

/test presubmit-nephio-go-test

@liamfallon
Copy link
Member Author

/retest

Copy link
Contributor

nephio-prow bot commented Nov 11, 2024

@liamfallon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
presubmit-nephio-go-test 98115d4 link true /test presubmit-nephio-go-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant