Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two warnings in repository.go #136

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Conversation

liamfallon
Copy link
Member

This PR fixes two code warnings in repository.go:

  • A double import
  • An unnecessary guard around a delete in a slice

@liamfallon
Copy link
Member Author

/test presubmit-nephio-go-test

@efiacor
Copy link
Collaborator

efiacor commented Nov 14, 2024

/approve
/lgtm

@liamfallon
Copy link
Member Author

/test presubmit-nephio-go-test

@liamfallon
Copy link
Member Author

/approve

Copy link
Contributor

nephio-prow bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liamfallon
Copy link
Member Author

/test presubmit-nephio-go-test

@efiacor efiacor merged commit 31ee5d5 into nephio-project:main Nov 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants