Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement improvements identified by static linting #138

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

liamfallon
Copy link
Member

  • Use "_" instead of names for unused function parameters
  • Use "_" instead of names for unused variables
  • Remove unused functions and variables
  • Replace fmt.Errorf with errors.New when error message contains no formatting

@nagygergo
Copy link
Contributor

Should the static checker be part of the pull_request github action?

@liamfallon
Copy link
Member Author

Should the static checker be part of the pull_request github action?

The static check is performed by VSCode in the background as one is coding. This static checker exists for go, it seems like a good idea to trigger this in a github action. I have added it to the agenda for discussion at the next SIG-3 meeting.

@efiacor
Copy link
Collaborator

efiacor commented Nov 14, 2024

/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liamfallon
Copy link
Member Author

/retest

@efiacor efiacor merged commit a343bce into nephio-project:main Nov 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants