-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Developer Env Setup script: add more automation steps #44
Developer Env Setup script: add more automation steps #44
Conversation
/title Developer Env Setup script: add more automation steps |
… for unit tests to run successfully
- make the setup script rely on local config files instead of remote ones from github - keep gitea deployment kpt package in .build directory (as opposed to a temp dir) in order to keep the local inventory for future updates - vscode: remove kpt-related folders from workspace - vscode: adopt porch-server launch paremeters to the porch components running in the test kind cluster
…h the go-client module
604ec1f
to
8aa0e94
Compare
Co-authored-by: Liam Fallon <[email protected]>
Co-authored-by: Liam Fallon <[email protected]>
Co-authored-by: Liam Fallon <[email protected]>
Co-authored-by: Liam Fallon <[email protected]>
Co-authored-by: Liam Fallon <[email protected]>
Co-authored-by: Liam Fallon <[email protected]>
Co-authored-by: Liam Fallon <[email protected]>
Co-authored-by: Liam Fallon <[email protected]>
Co-authored-by: Liam Fallon <[email protected]>
Co-authored-by: Liam Fallon <[email protected]>
Co-authored-by: Liam Fallon <[email protected]>
Co-authored-by: Liam Fallon <[email protected]>
Thanks. I will look into what we can do to eliminate the extra steps. |
Co-authored-by: Fiachra Corcoran <[email protected]>
Co-authored-by: Fiachra Corcoran <[email protected]>
…t package (instead of just flagging it to be ignored) Co-authored-by: Fiachra Corcoran <[email protected]>
…gned with the go-client module" This reverts commit 8aa0e94.
There is no need, it's not in your stuff and it's just the prehistoric version of bash and sed that MacOS uses. |
/approve |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: efiacor, kispaljr, liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This depends on #43
Automate even more steps of the tutorial: https://github.com/nephio-project/porch/tree/main/docs/tutorials/porch-development-environment.
The new steps added are detailed in the updated README.md file.
Please NOTE: Contrary to what the documentation says the end-to-end test will fail after executing the setup script. It is a known fact, and #57 was created to fix it.