Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer Env Setup script: add more automation steps #44

Merged
merged 32 commits into from
May 29, 2024

Conversation

kispaljr
Copy link
Collaborator

@kispaljr kispaljr commented May 8, 2024

This depends on #43

Automate even more steps of the tutorial: https://github.com/nephio-project/porch/tree/main/docs/tutorials/porch-development-environment.

The new steps added are detailed in the updated README.md file.

Please NOTE: Contrary to what the documentation says the end-to-end test will fail after executing the setup script. It is a known fact, and #57 was created to fix it.

@nephio-prow nephio-prow bot requested review from henderiw and tliron May 8, 2024 08:40
@kispaljr
Copy link
Collaborator Author

/title Developer Env Setup script: add more automation steps

@kispaljr kispaljr changed the title Developer Env Setup script: add certs and keys generation step Developer Env Setup script: add more automation steps May 13, 2024
@kispaljr kispaljr requested a review from liamfallon May 13, 2024 16:33
- make the setup script rely on local config files instead of remote ones from github
- keep gitea deployment kpt package in .build directory (as opposed to a temp dir) in order to keep the local inventory for future updates
- vscode: remove kpt-related folders from workspace
- vscode: adopt porch-server launch paremeters to the porch components running in the test kind cluster
kispaljr and others added 13 commits May 28, 2024 12:51
@kispaljr
Copy link
Collaborator Author

@kispaljr I ran through the tutorial on my macbook, once the bash and sed thing is done it works great!

Thanks. I will look into what we can do to eliminate the extra steps.

@liamfallon
Copy link
Member

@kispaljr I ran through the tutorial on my macbook, once the bash and sed thing is done it works great!

Thanks. I will look into what we can do to eliminate the extra steps.

There is no need, it's not in your stuff and it's just the prehistoric version of bash and sed that MacOS uses.

@efiacor
Copy link
Collaborator

efiacor commented May 29, 2024

/approve

@nephio-prow nephio-prow bot added the approved label May 29, 2024
@liamfallon
Copy link
Member

/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, kispaljr, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot merged commit e190648 into nephio-project:main May 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants