Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TestDeleteFromMain from flat waiting times to active monitoring #63

Closed

Conversation

nagygergo
Copy link
Contributor

Minor improvement, moves test case execution time from 150 to 70 seconds.

Also waitUntilMainBranchPackageRevisionExists was incorrectly implemented, it was not looking for a specific package having a main revision, but any package.

@nephio-prow nephio-prow bot requested review from henderiw and s3wong May 31, 2024 14:42
Copy link
Contributor

nephio-prow bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nagygergo
Once this PR has been reviewed and has the lgtm label, please assign tliron for approval by writing /assign @tliron in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

nephio-prow bot commented May 31, 2024

Hi @nagygergo. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nagygergo
Copy link
Contributor Author

Closing in favor of #57 , which also offers a fix for the same thing.

@nagygergo nagygergo closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant