Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in the development process #72

Merged
merged 11 commits into from
Jun 18, 2024

Conversation

kispaljr
Copy link
Collaborator

This PR contains the following improvements:

  • updated documentation explaining the improved development process
  • fix a bug that prevented running porch with a local porch-server on Docker Desktop setups (e.g. MacOS)
  • docker image builds work even if the git repo is cloned into a directory named other than "porch"
  • add new make targets: run-in-kind-no-server, run-in-kind-no-controller, deployment-config-no-server, deployment-config-no-controller
  • improve caching during controller docker image build
  • better detection of a Docker Desktop setup
  • dev-env setup script moved to ./scripts
  • dev-env setup script doesn't install porch anymore.
    (It can be done instead by the make targets: run-in-kind, run-in-kind-no-server, run-in-kind-no-controller)
  • make help is now more verbose

- fix bug that prevented running porch with a local porch-server on MacBooks
- docker image builds work even if the git repo is cloned into a repository not called "porch"
- add new make targets: run-in-kind-no-server, run-in-kind-no-controller, deployment-config-no-server, deployment-config-no-controller
- dev-env setup script moved to ./scripts
- dev-env setup script doesn't install porch anymore.
  It can be done instead by the make targets: run-in-kind, run-in-kind-no-server, run-in-kind-no-controller
- `make help` is now more verbose
Better detection of Docker Desktop setup.
@kispaljr
Copy link
Collaborator Author

/retest

@liamfallon
Copy link
Member

This is great @kispaljr, It's a nice approach to use the latest deployment and then remove the bits that are being developed locally rather than doing a separate deployment for development. Allowing the developers to select and easily switch between the parts they want to develop on is really useful.

I ran all the make targets locally and it all works fine for me.

@liamfallon
Copy link
Member

/lgtm
/approve

@nephio-prow nephio-prow bot removed the lgtm label Jun 17, 2024
@liamfallon
Copy link
Member

/approve
/lgtm

@nephio-prow nephio-prow bot added the lgtm label Jun 17, 2024
Copy link
Contributor

nephio-prow bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kispaljr, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liamfallon
Copy link
Member

This PR must be caught in Tide

@radoslawc radoslawc merged commit 490e9c9 into nephio-project:main Jun 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants