-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements in the development process #72
Conversation
- fix bug that prevented running porch with a local porch-server on MacBooks - docker image builds work even if the git repo is cloned into a repository not called "porch" - add new make targets: run-in-kind-no-server, run-in-kind-no-controller, deployment-config-no-server, deployment-config-no-controller - dev-env setup script moved to ./scripts - dev-env setup script doesn't install porch anymore. It can be done instead by the make targets: run-in-kind, run-in-kind-no-server, run-in-kind-no-controller - `make help` is now more verbose
Better detection of Docker Desktop setup.
/retest |
Co-authored-by: Liam Fallon <[email protected]>
This is great @kispaljr, It's a nice approach to use the latest deployment and then remove the bits that are being developed locally rather than doing a separate deployment for development. Allowing the developers to select and easily switch between the parts they want to develop on is really useful. I ran all the make targets locally and it all works fine for me. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kispaljr, liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR must be caught in Tide |
This PR contains the following improvements:
run-in-kind-no-server
,run-in-kind-no-controller
,deployment-config-no-server
,deployment-config-no-controller
./scripts
(It can be done instead by the make targets: run-in-kind, run-in-kind-no-server, run-in-kind-no-controller)
make help
is now more verbose