Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script for extracting timestamped entries from e2e test logs #268

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

liamfallon
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This PR adds a python script that extracts timestamped logs from the e2e log file, formats them as CSV files, and determines if the time interval between two adjacent log entries is a long delay. The CSV files can then be pulled into a spreadsheet and analysed.

Which issue(s) this PR fixes:
Related to:
nephio-project/nephio#462

Special notes for your reviewer:
None

Does this PR introduce a user-facing change?:
None

@radoslawc
Copy link
Collaborator

/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented Jun 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: radoslawc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jun 10, 2024
@electrocucaracha
Copy link
Member

electrocucaracha commented Jun 10, 2024

@liamfallon maybe this script is not required, we're collecting and printing duration metrics here, let me know if that's not sufficient.

@liamfallon
Copy link
Member Author

/retest

@nephio-prow nephio-prow bot merged commit 06ed4d6 into nephio-project:main Jun 11, 2024
5 of 6 checks passed
@vjayaramrh
Copy link
Collaborator

@radoslawc it seems like the PR is getting merged with just one approve. How can we ensure 2 lgtm's are present before it gets approved and also if there are any comments, it should be resolved before it gets merged. Thanks

@liamfallon liamfallon deleted the log_timestamp_script branch June 12, 2024 08:04
dkosteck pushed a commit to vjayaramrh/test-infra that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants