Make SharedVar.wait*() methods return bool to signal if timeout was reached
#132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgodlewski
force-pushed
the
kg/shared-var-wait-returns-bool
branch
2 times, most recently
from
86f6f7d to
f68e12a
Compare
This is the return value of `multiprocessing.Condition.wait*()`, signalling whether timeout was reached or not.
kgodlewski
force-pushed
the
kg/shared-var-wait-returns-bool
branch
from
f68e12a to
60aa4dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the return value of
multiprocessing.Condition.wait*(), signalling whether timeout was reached or not -- it's useful/necessary for some tests. This change will not affect existing code, as the previous return value wasNoneand is not checked anywhere.Some method docstrings are also modified/added.