Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file upload support #134

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Add file upload support #134

wants to merge 12 commits into from

Conversation

kgodlewski
Copy link
Contributor

@kgodlewski kgodlewski commented Feb 13, 2025

Todo list before moving out of draft mode:

  • add unit tests
  • add e2e tests
  • update neptune-api version in pyproject.toml, .pre-commit-config.yaml, and dev_requirements.txt once it's released
  • test impact of transferring large BytesIO between processes

@kgodlewski kgodlewski force-pushed the kg/file-atoms-support branch 2 times, most recently from 3a7d51f to 561111c Compare February 13, 2025 15:05
# Conflicts:
#	src/neptune_scale/sync/sync_process.py
This is the return value of `multiprocessing.Condition.wait*()`,
signalling whether timeout was reached or not.
@kgodlewski kgodlewski force-pushed the kg/file-atoms-support branch from 561111c to c5f5748 Compare February 13, 2025 15:10
These two classes are responsible for the file
upload process.
Version 12.7.0 is the lowest we can go with the API
being used. It's 4 years old, so we should be good.
@kgodlewski kgodlewski force-pushed the kg/file-atoms-support branch from c5f5748 to de4d08a Compare February 14, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant