Add Hostname to experiment creation (#75)

neptune-ai · Apr 2, 2019 · 34ace33 · 34ace33
1 parent a881a31
commit 34ace33
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 6 deletions.
diff --git a/neptune/__init__.py b/neptune/__init__.py
@@ -69,7 +69,8 @@ def create_experiment(name=None,
                       send_hardware_metrics=True,
                       run_monitoring_thread=True,
                       handle_uncaught_exceptions=True,
-                      git_info=None):
+                      git_info=None,
+                      hostname=None):
     # pylint: disable=global-statement
     global project
     if project is None:
@@ -88,7 +89,8 @@ def create_experiment(name=None,
         send_hardware_metrics=send_hardware_metrics,
         run_monitoring_thread=run_monitoring_thread,
         handle_uncaught_exceptions=handle_uncaught_exceptions,
-        git_info=git_info
+        git_info=git_info,
+        hostname=hostname
     )
 
 

diff --git a/neptune/client.py b/neptune/client.py
@@ -196,7 +196,17 @@ def get_metrics_csv(self, experiment):
                 experiment_short_id=experiment.id, project_qualified_name=experiment._project_full_id)
 
     @with_api_exceptions_handler
-    def create_experiment(self, project, name, description, params, properties, tags, abortable, monitored, git_info):
+    def create_experiment(self,
+                          project,
+                          name,
+                          description,
+                          params,
+                          properties,
+                          tags,
+                          abortable,
+                          monitored,
+                          git_info,
+                          hostname):
         ExperimentCreationParams = self.backend_swagger_client.get_model('ExperimentCreationParams')
         GitInfoDTO = self.backend_swagger_client.get_model('GitInfoDTO')
         GitCommitDTO = self.backend_swagger_client.get_model('GitCommitDTO')
@@ -227,7 +237,8 @@ def create_experiment(self, project, name, description, params, properties, tags
                 entrypoint="",  # FIXME
                 execArgsTemplate="",  # FIXME,
                 abortable=abortable,
-                monitored=monitored
+                monitored=monitored,
+                hostname=hostname
             )
 
             api_experiment = self.backend_swagger_client.api.createExperiment(

diff --git a/neptune/projects.py b/neptune/projects.py
@@ -221,7 +221,8 @@ def create_experiment(self,
                           send_hardware_metrics=True,
                           run_monitoring_thread=True,
                           handle_uncaught_exceptions=True,
-                          git_info=None):
+                          git_info=None,
+                          hostname=None):
         """
         Raises:
             `ExperimentValidationError`: When provided arguments are invalid.
@@ -257,7 +258,8 @@ def create_experiment(self,
             tags=tags,
             abortable=abortable,
             monitored=run_monitoring_thread,
-            git_info=git_info
+            git_info=git_info,
+            hostname=hostname
         )
 
         experiment.start(