Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow allocated project name to be displayed in Coldfront UI on detailed Project view #119

Merged
merged 1 commit into from
May 29, 2024

Conversation

QuanMPhm
Copy link
Contributor

Closes #118 , I've edited the local_settings.py to allow the Allocated Project Name setting be displayed

@knikolla
Copy link
Collaborator

@QuanMPhm have you done some testing and can share some pictures showing how it looks? Also can you see what happens if an allocation doesn't have that attribute yet?

@QuanMPhm
Copy link
Contributor Author

QuanMPhm commented May 29, 2024

@knikolla This is what I see when running the coldfront-nerc docker-compose file. The allocation for "Chemistry-cgray" has the attribute "Allocated Project Name" and "Allocated Project ID" set, but only the former is shown.

If an allocation does not have "Allocated Project Name" attribute set, nothing is shown in the information column.
Screenshot 2024-05-29 at 4 48 41 PM

@QuanMPhm
Copy link
Contributor Author

Is it a good idea to share screenshots like this on Github?

@knikolla
Copy link
Collaborator

Is it a good idea to share screenshots like this on Github?

As long as it doesn't have any private information, yes. Thanks.

@knikolla
Copy link
Collaborator

@Milstein @jtriley the above change is a user-facing change that will show an allocation's Allocated Project Name in the allocations list of a project as per screenshot above.

@knikolla knikolla requested review from jtriley and Milstein May 29, 2024 20:55
@jtriley jtriley merged commit afa81ba into nerc-project:main May 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Allocated Project Name in Project Detail
3 participants