Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update fiber graph node attributes #2397

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

rabbitz
Copy link
Collaborator

@rabbitz rabbitz commented Jan 8, 2025

No description provided.

@rabbitz rabbitz requested a review from zmcNotafraid January 8, 2025 05:52
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.33%. Comparing base (f373f6b) to head (7b67d81).
Report is 586 commits behind head on develop.

Files with missing lines Patch % Lines
...controllers/api/v2/fiber/graph_nodes_controller.rb 0.00% 1 Missing ⚠️
app/models/suggest_query.rb 0.00% 1 Missing ⚠️
app/serializers/fiber_graph_node_serializer.rb 0.00% 1 Missing ⚠️
app/workers/fiber_graph_detect_worker.rb 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f373f6b) and HEAD (7b67d81). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f373f6b) HEAD (7b67d81)
2 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2397       +/-   ##
============================================
- Coverage    67.56%   55.33%   -12.23%     
============================================
  Files          289      374       +85     
  Lines         7944    10760     +2816     
============================================
+ Hits          5367     5954      +587     
- Misses        2577     4806     +2229     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rabbitz rabbitz added this pull request to the merge queue Jan 8, 2025
Merged via the queue into nervosnetwork:develop with commit e46063e Jan 8, 2025
1 of 3 checks passed
@rabbitz rabbitz deleted the feat/fiber branch January 8, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants