-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ckb-jsonrpc-types
#85
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eval EXEC <[email protected]>
EthanYuan
force-pushed
the
add-jsonrpc-types
branch
from
August 10, 2023 08:36
f496d75
to
1af4f5d
Compare
EthanYuan
force-pushed
the
add-jsonrpc-types
branch
from
August 21, 2023 12:42
1af4f5d
to
591d5e7
Compare
Replace this PR with #92 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Content
ckb-jsonrpc-types
into this project. We propose that theckb-sdk-rust
should maintain its ownjsonrpc-types
, facilitating the addition of developer-friendly features.jsonrpc-types
to provide deserialization-friendly enhancements forResponseFormat
andBlockResponse
.jsonrpc-types
, we've refactored methods inCkbRpcClient
that are related toResponseFormat
and
BlockResponse
.Deprecation Notice
Building on the aforementioned changes, a deprecation notice has been added to the pub trait
ResponseFormatGetter
, in preparation for its future deprecation in upcoming versions.More Details
based on pr
v0.111.0
#80add methods for
ResponseFormat
add method for
BlockResponse